Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humanize.times is broken for node #27

Closed
aaylward opened this issue Jun 21, 2013 · 0 comments
Closed

Humanize.times is broken for node #27

aaylward opened this issue Jun 21, 2013 · 0 comments
Labels
bug

Comments

@aaylward
Copy link
Contributor

times references window.isFinite via the local isFinite helper. window is undefined in node. There were previously no tests for the times method, but even if there had been, the jasmine test runner creates a mock window object which would have masked the problem.
aaylward added a commit that referenced this issue Jun 21, 2013
@aaylward
times fix for node fixes #27
8808b70 
 - also added some tests
aaylward added a commit that referenced this issue Jun 21, 2013
@aaylward
Merge pull request #28 from HubSpot/timesFix
1774e90 
Times fix - fixes #27
aaylward added a commit that referenced this issue Jun 21, 2013
@aaylward
Merge pull request #29 from HubSpot/timesFixMaster
5893b16 
fixes #27
@aaylward aaylward mentioned this issue Jun 21, 2013
Closed
aaylward added a commit that referenced this issue Jun 21, 2013
@aaylward
more info re: #27
31ff291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaylward