Add resolved expressions recursively up the context chain #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
addResolvedFrom
to combine resolved expressions from multipleContext
objects, it would be more widely applicable to recursively add resolved expressions up the parent context chain. This way information isn't lost when rendering a nested structure, with multiple nested contexts and resolved expressions.@boulter do you think this would be worth applying to
Context
's resolved functions and values as well?cc @hs-lsong