Create new class that lazily resolves #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an explicit class |
mattcoley
changed the title
boulter
approved these changes
Aug 7, 2019
|
|
||
| public class LazyExpression implements Supplier { | ||
|
|
||
| private final Supplier supplier; |
There was a problem hiding this comment.
Should this be Supplier<?>?
There was a problem hiding this comment.
Or perhaps Supplier<Object>. Maybe that's redundant.
There was a problem hiding this comment.
Supplier and Supplier<Object> will compile down to the same code due to how generics work in Java (IIRC) so it won't make a difference.
There was a problem hiding this comment.
This is also only used to return a generic object from the interpreter resolve method so I think this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be controversial.
Suppliers are nice to use when a variable that is set in the context that is expensive to calculate may not end up being used. Instead of handling each case individually, we can allow suppliers to be used and automatically call the
get()function when we resolve an expression that returns a supplier.As an example use case, if you are currently building a context map (
Map<String, Object>) and want to lazily generate some of the values, you can replace them with suppliers, and due to this PR, the suppliers will auto-resolve.