fix: for broken scene and avatar media links with newLoader #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikk15
changed the title
takahirox
reviewed
Aug 9, 2023
| image={imageDef} | ||
| /> | ||
| ); | ||
| return renderAsEntity(world, <entity name="Image" image={imageDef} />); |
There was a problem hiding this comment.
Quick question to confirm: Is this change just for formatting?
|
Thanks for working on it! If possible, would you mind explaining how the problem happened (what is the root cause?) and how the problem is fixed with the change for easier review? |
takahirox
reviewed
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were not hitting the block of code that fetches the correct url for these assets, and placing scenes or avatars with the newLoader resulted in broken links.
For now, you may test here: https://nikk15.dev.myhubs.net/k95eyHn/elegant-grounded-convention/?newLoader=
Previous:
