Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the subscription queries so that result bundles won't trigger notifications. #100

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Fix the subscription queries so that result bundles won't trigger notifications. #100

merged 1 commit into from
Sep 4, 2018

Conversation

rexwangcc
Copy link
Member

Please ensure the following when opening a PR:

  • Added or updated tests
  • Updated documentation
  • Applied style guidelines
  • Considered generalizability beyond our own use case

dshiga
dshiga approved these changes Sep 4, 2018
View reviewed changes
Copy link
Contributor

@dshiga dshiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the query against blue box to make sure it excludes analysis bundles?

@rexwangcc
Copy link
Member Author

@dshiga Yep, I tested both queries, they excluded the analysis bundles and also included the primary bundles.

@rexwangcc rexwangcc merged commit c15384f into master Sep 4, 2018
@rexwangcc rexwangcc deleted the cw-fix-ubscription-queries branch September 4, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samanehsan samanehsan samanehsan approved these changes

@dshiga dshiga dshiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexwangcc @dshiga @samanehsan