Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: DEV-3666: Fix maxUsages on regions creation #1021

Merged
merged 11 commits into from
Feb 1, 2023

Conversation

Gondragos
Copy link
Contributor

No description provided.

@swarmia
Copy link

swarmia bot commented Nov 17, 2022

# Conflicts:
#	e2e/codecept.conf.js
#	e2e/fragments/AtParagraphs.js
#	e2e/fragments/AtRichText.js
#	src/mixins/DrawingTool.js
#	src/mixins/SelectedModel.js
#	src/tags/object/Base.js
#	src/tags/object/Image.js
#	src/tags/object/Paragraphs/Model.js
#	src/tools/Brush.js
#	src/tools/KeyPoint.js
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2022

Codecov Report

Base: 9.41% // Head: 9.41% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e61797d) compared to base (a089615).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1021      +/-   ##
=========================================
- Coverage    9.41%   9.41%   -0.01%     
=========================================
  Files         109     109              
  Lines        7783    7799      +16     
  Branches     1950    1963      +13     
=========================================
+ Hits          733     734       +1     
- Misses       5907    5915       +8     
- Partials     1143    1150       +7     
Impacted Files Coverage Δ
src/src/tags/object/Base.js 5.12% <0.00%> (-0.59%) ⬇️
src/src/tools/KeyPoint.js 10.00% <0.00%> (-0.53%) ⬇️
src/src/mixins/SelectedModel.js 1.92% <0.00%> (-0.12%) ⬇️
src/src/tools/Brush.js 5.35% <0.00%> (-0.05%) ⬇️
src/src/tags/object/Image.js 2.86% <0.00%> (-0.03%) ⬇️
src/src/mixins/DrawingTool.js 1.12% <0.00%> (-0.01%) ⬇️
src/src/utils/feature-flags.ts 98.07% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good here, but I see we have a FF for a fix - since this is not a breaking change - do we need that FF? if not can you remove it as I think this fix should apply to everyone

# Conflicts:
#	e2e/codecept.conf.js
#	src/utils/feature-flags.ts
# Conflicts:
#	e2e/fragments/AtAudioView.js
#	src/tags/object/Image.js
#	src/utils/feature-flags.ts
src/tags/object/Base.js Outdated Show resolved Hide resolved
@Gondragos Gondragos merged commit ade7295 into master Feb 1, 2023
@Gondragos Gondragos deleted the fb-dev-3666/max-usages branch February 1, 2023 18:41
hlomzik added a commit to HumanSignal/label-studio that referenced this pull request Mar 26, 2024
hlomzik added a commit to HumanSignal/label-studio that referenced this pull request Mar 27, 2024
* feat: LEAP-219: Update LSF E2E with recent changes

- HumanSignal/label-studio-frontend#1192 for Magic Wand from @BradNeuberg
- HumanSignal/label-studio-frontend#1708 with external images problem
- HumanSignal/label-studio-frontend#1021 for maxUsages missed for some reason

* Fix newlines in all LSF E2E from CRLF to LF

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429166524

* Update web/libs/editor/tests/e2e/tests/ner-text.test.js

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429666577

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Co-authored-by: bmartel <brandonmartel@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants