-
Notifications
You must be signed in to change notification settings - Fork 316
fix: DEV-3666: Fix maxUsages on regions creation #1021
Conversation
✅ Linked to Bug DEV-3666 · maxUsages for KeyPointLabels and RectangleLabels doesn't work |
# Conflicts: # e2e/codecept.conf.js # e2e/fragments/AtParagraphs.js # e2e/fragments/AtRichText.js # src/mixins/DrawingTool.js # src/mixins/SelectedModel.js # src/tags/object/Base.js # src/tags/object/Image.js # src/tags/object/Paragraphs/Model.js # src/tools/Brush.js # src/tools/KeyPoint.js
Codecov ReportBase: 9.41% // Head: 9.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
=========================================
- Coverage 9.41% 9.41% -0.01%
=========================================
Files 109 109
Lines 7783 7799 +16
Branches 1950 1963 +13
=========================================
+ Hits 733 734 +1
- Misses 5907 5915 +8
- Partials 1143 1150 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good here, but I see we have a FF for a fix - since this is not a breaking change - do we need that FF? if not can you remove it as I think this fix should apply to everyone
# Conflicts: # e2e/codecept.conf.js # src/utils/feature-flags.ts
# Conflicts: # e2e/fragments/AtAudioView.js # src/tags/object/Image.js # src/utils/feature-flags.ts
- HumanSignal/label-studio-frontend#1192 for Magic Wand from @BradNeuberg - HumanSignal/label-studio-frontend#1708 with external images problem - HumanSignal/label-studio-frontend#1021 for maxUsages missed for some reason
* feat: LEAP-219: Update LSF E2E with recent changes - HumanSignal/label-studio-frontend#1192 for Magic Wand from @BradNeuberg - HumanSignal/label-studio-frontend#1708 with external images problem - HumanSignal/label-studio-frontend#1021 for maxUsages missed for some reason * Fix newlines in all LSF E2E from CRLF to LF * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429166524 * Update web/libs/editor/tests/e2e/tests/ner-text.test.js * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/8429666577 --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: bmartel <brandonmartel@gmail.com>
No description provided.