Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize extension reinstantiates Regex objects unnecessarily #353

Closed
dlras2 opened this issue Nov 29, 2014 · 0 comments
Closed

Humanize extension reinstantiates Regex objects unnecessarily #353

dlras2 opened this issue Nov 29, 2014 · 0 comments

Comments

@dlras2
Copy link
Contributor

dlras2 commented Nov 29, 2014

StringHumanizeExtensions.Humanize and StringHumanizeExtensions.FromPascalCase are reinstantiating their respective Regex objects on every call. These constructor calls can make up over half the execution time of Humanize(), as seen in the screenshot below. This can be fixed by using the cached static Regex.IsMatch method or instantiating the necessary Regex only in the static constructor of StringHumanizeExtensions.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants