added Slovak localization (strings, formatter, tests) #124
Conversation
|
Thanks for this. As mentioned in the issue you've raised we will have to fix DateTimeHumanize tests for all locales by extracting the Verify method out of the base |
| [InlineData(10, "o 10 sekúnd")] | ||
| public void NSecondsFromNow(int number, string expected) | ||
| { | ||
| var humanize = DateTime.UtcNow.AddSeconds(number).Humanize(); |
There was a problem hiding this comment.
We try to do one line tests by inlining the calculation and assertions. Please online the humanize in all tests.
|
I need to fix up a few things on DateTime tests; so if you could fix up the review comments, extract the Verify method, clean up the DateTime tests, apply Verify on your tests and push it up. |
|
I have made the changes |
added Slovak localization (strings, formatter, tests)
|
Thanks for this. The tests still fail randomly. So I will have to apply the fix soon. |
|
The tests were fixed on #131. This is now released as v1.17.1. Thanks. |
No description provided.