Refactoring of verification #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [Fact] | ||
| public void OneSecondFromNow() | ||
| { | ||
| var oneSecondFromNow = Resources.GetResource(ResourceKeys.DateHumanize.GetResourceKey(TimeUnit.Second, TimeUnitTense.Future, count: 1)); | ||
| Verify(oneSecondFromNow, new TimeSpan(0, 0, 0, 1)); | ||
| DateVerification.Verify(oneSecondFromNow, new TimeSpan(0, 0, 0, 1)); |
There was a problem hiding this comment.
I don't know why I used new TimeSpan here. I think we should use TimeSpan.Fromxxx methods instead; e.g. TimeSpan.FromSeconds(1).
There was a problem hiding this comment.
In fact looking at this class, I think it should be completely refactored to look like new DateTime.Humanize tests (e.g. Arabic ones). See #125
|
Sorry. I had to make this fix ASAP because we have random failing tests on CI. So I created #131 that supersedes this. I would appreciate if you could please review. Thanks for the initiative and getting the ball rolling. |
|
No worries. I will take a look regarding your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress