Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swedish localization (strings, tests) #135

Merged
merged 4 commits into from
Apr 9, 2014
Merged

Conversation

ekblom
Copy link
Contributor

@ekblom ekblom commented Apr 9, 2014

Here is a swedish localization

@MehdiK
Copy link
Member

MehdiK commented Apr 9, 2014

Thanks.

Please add the PR to the release-notes file and also write some unit tests based on some of the existing ones - although I think you don't need those many cases as your translation rules are quite simple and map one-to-one to English.

Also you need to do two sets of tests for DateTime and TimeSpan. You can see examples of this in the other localisations.

@ekblom ekblom changed the title Swedish translation Swedish localization Apr 9, 2014
@ekblom ekblom changed the title Swedish localization Swedish localization (strings, tests) Apr 9, 2014
@ekblom
Copy link
Contributor Author

ekblom commented Apr 9, 2014

Added tests for DateTime and TimeSpan, removed some necessary tests and added the info to the release notes (hopefully in the correct way).

@@ -1,5 +1,7 @@
###In Development

- [#135](https://github.com/MehdiK/Humanizer/pull/135): Swedish localization (strings, tests)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It's cool.

@MehdiK
Copy link
Member

MehdiK commented Apr 9, 2014

Cool. Thanks. I will fix the spacing issues and merge. Don't worry about them.

@MehdiK MehdiK merged commit f804b42 into Humanizr:master Apr 9, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 9, 2014

Thanks for your contribution. This is now released to nuget as v1.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants