Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dutch numbers to words support #166

Merged
merged 7 commits into from
Apr 12, 2014

Conversation

ryanheath
Copy link
Contributor

No description provided.

{
public class NumberToOrdinalWordsTests : AmbientCulture
{
public NumberToOrdinalWordsTests() : base("nl-NL") { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some weird spacing issues throughout the code! Please reformat your code.

@MehdiK
Copy link
Member

MehdiK commented Apr 10, 2014

There are 10 failing unit tests. Please fix these. Also please add your PR to the release-notes file.

@ryanheath
Copy link
Contributor Author

Wow, how did that happen?!

I'll fix it shortly!

// Ryan

On Thu, Apr 10, 2014 at 4:50 PM, Mehdi Khalili notifications@gh.neting.ccwrote:

There are 10 failing unit tests. Please fix these. Also please add your PR
to the release-notes file.

Reply to this email directly or view it on GitHubhttps://github.com//pull/166#issuecomment-40092375
.

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Sorry. GitHub doesn't send notifications for new commits and your changes slipped under my radar. Now the whole thing has changed so much it's quite hard to rebase your changes o_O

I think the easiest way would be for you to pull from upstream and apply your changes again as rebase is going to be quite painful. Sorry

@ryanheath
Copy link
Contributor Author

I have rebased my changes on the latest version.

// Ryan

On Sat, Apr 12, 2014 at 3:29 PM, Mehdi Khalili notifications@gh.neting.ccwrote:

Sorry. GitHub doesn't send notifications for new commits and your changes
slipped under my radar. Now the whole thing has changed so much it's quite
hard to rebase your changes o_O

I think the easiest way would be for you to pull from upstream and apply
your changes again as rebase is going to be quite painful. Sorry

Reply to this email directly or view it on GitHubhttps://github.com//pull/166#issuecomment-40280355
.

@MehdiK MehdiK merged commit 5e2ffe7 into Humanizr:master Apr 12, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

Splendid! Thanks a lot.

@MehdiK
Copy link
Member

MehdiK commented Apr 14, 2014

This is now on NuGet as v1.22.1. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants