Added Gender for ToOrdinalWords (needed for Brazilian Portuguese) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added pt-br localisation gender for number to words. Added pt-br localisation for ordinal words, with gender.
|
I also moved the OrdinalTests from English to |
|
Is it safe to review/merge this now? :p |
|
Yes. Just updated the readme, I believe it is all set now. |
| @@ -436,6 +436,16 @@ This is kind of mixing `ToWords` with `Ordinalize`. You can call `ToOrdinalWords | |||
| 121.ToOrdinalWords() => "hundred and twenty first" | |||
| ``` | |||
|
|
|||
| `ToOrdinalWords` also supports `GrammaticalGender`, you can pass a second argument to `ToOrdinalWords` to specify which gender the number should be outputted in. The possible values are `GrammaticalGender.Masculine`, `GrammaticalGender.Feminine` and `GrammaticalGender.Neuter`. | |||
There was a problem hiding this comment.
Thanks a lot for updating the readme :)
There was a problem hiding this comment.
Please also explain that this is applicable to some culture only.
|
Updated readme explaining Gender for Ordinal is optional and added an example of pt-br Neutral gender. |
|
Merged now. I made a few small changes to the converter and the readme. I would appreciate your review. |
|
This was a great clean PR. Thanks for the great work :) |
|
This is now published to NuGet as v1.21.1. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pt-br localisation gender for number to words.
Added pt-br localisation for ordinal words, with gender.