Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resources.ar.resx #231

Merged
merged 3 commits into from
Apr 18, 2014
Merged

Update Resources.ar.resx #231

merged 3 commits into from
Apr 18, 2014

Conversation

kikoanis
Copy link
Contributor

Added more settings for FromNow, Dual and Plural

@MehdiK
Copy link
Member

MehdiK commented Apr 18, 2014

Please write unit tests for the added resources. Here is some examples.

Also add your PR to the release-notes file. Thanks.

@kikoanis
Copy link
Contributor Author

Done... Thanks

MehdiK added a commit that referenced this pull request Apr 18, 2014
@MehdiK MehdiK merged commit 76cc483 into Humanizr:master Apr 18, 2014
@MehdiK
Copy link
Member

MehdiK commented Apr 18, 2014

Cool. Thanks for the addition.

@MehdiK
Copy link
Member

MehdiK commented Apr 18, 2014

If you're interested ToWords and ToOrdinalWords can be localised too! From the contribution guideline:

Translations for ToWords and ToOrdinalWords methods are currently done in code as there is a huge difference between the way different languages deal with number words. Check out Dutch and Russian localisations for examples of how you can write a Converter for your language. You should then register your converter in the ConverterFactory for it to kick in on your locale.

Don't forget to write tests for your localisations. Check out the existing DateHumanizeTests, TimeSpanHumanizeTests and NumberToWordsTests.

@MehdiK
Copy link
Member

MehdiK commented Apr 19, 2014

Thanks for the contribution. This is now available on NuGet as v1.23.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants