New command-line build and verify #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,8 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 2012 | |||
There was a problem hiding this comment.
Is it necessary to change the Visual Studio version?
There was a problem hiding this comment.
I guess it's not necessary, but they are still backwards compatible.
|
@adamchester It looks good! I left a few comments that, I think, can be easily addressed. :) |
|
Cool. Thanks a lot guys for the work and discussions. @adamchester #230 is in. Please let me know when you're happy with this and I can merge it. |
by using `build.cmd` from a VS command line, in the root project folder, the following happens (by default): - the solution is built in Release and Verify configurations - in the new Verify configuration, code analysis, and msbuild 'treat warnings as errors' are enabled. CA ruleset is based on the 'Microsoft Managed Recommended Rules' from VS 2013. All enabled rules are set to error on violations. - Xunit tests are executed, reporting any errors This is based on the Albedo project (https://github.com/ploeh/Albedo). I removed the nuget and versioning-related tasks. They could be added back if needed.
|
OK, I think it's ready :) |
| <Target Name="CleanVerify"> | ||
| <MSBuild Projects="@(ProjectToBuild)" Targets="Clean" Properties="Configuration=Verify" /> | ||
| </Target> | ||
| <Target Name="CleanRelease"> |
There was a problem hiding this comment.
Why do we need to run Release too?
|
This is awesome. Thanks for the great work @adamchester :) I added this to release-notes and readme files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new command-line build and verify. Using
build.cmdfrom a VS command line, in the root project folder, the following happens (by default):Sample output:
This is based on the Albedo project. I removed the nuget and versioning-related tasks. They could be added back if needed.
// cc @moodmosaic - would appreciate your feedback, if you can :)