Added byte rate calculation functons, closes #296

[GeorgeHahn]

API is var rateString = bytesize.Per(timespan).ToRatePerSecond();

[mexx]

Please change the property names to CamelCase.

[mexx]

The CI build is failing because of missing XML comments on ByteSize class and its properties.
Please add them.

Also please review contribution guidelines

• Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
• Readme is updated if you change an existing feature or add a new one
• An entry is added in the release_notes.md file in the 'In Development' section with a link to your PR and a description of what's changed. Please follow the wording style for the description.

[MehdiK]

I am not sure why you're setting text, size and measurementInterval variables here again!! I am removing them. Please remove them.

[GeorgeHahn]

Shoot, I was playing with the API and totally forgot to remove it when I was done!

[MehdiK]

You have a failing test. Please run all the tests and fix the ApiApprover test.

[GeorgeHahn]

The ApiApprover test doesn't run on my machine, but I've taken a crack at fixing it. I believe I've addressed the other issues noted above.

E: Looks like I failed to fix the ApiApprover test. It doesn't look like I can download the generated text file that's being tested against from TC, is there any chance you could gist it?

[mexx]

This line should move to the development section.
@MehdiK why do you release stuff while other are still developing 😠 :ironic:

[MehdiK]

Looks like I failed to fix the ApiApprover test. It doesn't look like I can download the generated text file that's being tested against from TC, is there any chance you could gist it?

When the test fails you should see a diff tool popping up showing the expected text. Not sure why it's not working on your machine! Can you run it using a different runner?

Please rebase your work on top of the upstream & move the release notes up to the dev section. Thanks.

[mexx]

Finally I've found some time to fix the ApiApprover test.
@GeorgeHahn Thanks for your contribution.

[GeorgeHahn]

Thanks Max! My apologies for not fixing the test myself. I've tried it on three different pc's since the dialog here and have yet to see it run correctly.

On Thu, Aug 7, 2014 at 5:12 PM, Max Malook notifications@github.com
wrote:

Finally I've found some time to fix the ApiApprover test.

@GeorgeHahn Thanks for your contribution.

Reply to this email directly or view it on GitHub:
#314 (comment)

[MehdiK]

@mexx thanks for fixing, rebase and pushing this up. You're awesome. Just one small thing: please use merge --no-ff to retain the PR bump on the commit graph.

[MehdiK]

This is now released to NuGet as v1.29.0. Thanks for the great addition and your collaboration.