Added Italian localisation and tests #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 18, 2014 13:11
Comparing to english collection format, avoid last comma before default separator.
Also: code formatting on base constructor invocation.
Also: rename identifiers in ItaliaCardinaNumberCruncher
added 9 commits
August 26, 2014 23:16
BrainCrumbz
changed the title
|
|
||
| var enumerable = collection as T[] ?? collection.ToArray(); | ||
|
|
||
| int count = enumerable.Count(); |
There was a problem hiding this comment.
Should be int count = enumerable.Length;
|
Not sure Github sends notifications for line notes. Edits proposed after review have been commited. |
|
Haha, no it doesn't. Thanks for letting us know. I'll try to review it tomorrow. Sorry it took me a while. It's been crazy
|
|
This has now been merged. Thanks. |
|
This is now released to NuGet as v1.29.0. Thanks for the great contribution and your patience :) |
|
More than welcome. Happy to contribute! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added date and time resources, collection formatter, number-to-words converters (cardinal and ordinal), ordinalizer.
We're just figuring out what to add in release_notes.md