Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a build target for .NET 4.0 Client Profile. #431

Merged
merged 1 commit into from
Jun 28, 2015
Merged

Added a build target for .NET 4.0 Client Profile. #431

merged 1 commit into from
Jun 28, 2015

Conversation

PhyxionNL
Copy link
Contributor

This is for #308 and is by far the easiest solution without having to copy everything constantly around. If this is accepted, it would be nice to update NuGet as well. I also changed the build.bat to include the 4.0 CP.

MehdiK added a commit that referenced this pull request Jun 28, 2015
Added a build target for .NET 4.0 Client Profile.
@MehdiK MehdiK merged commit c7030c7 into Humanizr:master Jun 28, 2015
@MehdiK
Copy link
Member

MehdiK commented Jun 28, 2015

Thanks @Phyxion. I've merged this. The NuGet update would require publishing two separate packages: one for CPL and one for 4.0 CP I believe, right?

@PhyxionNL
Copy link
Contributor Author

@MehdiK
Copy link
Member

MehdiK commented Jul 2, 2015

Thanks for the contribution. This is now released to NuGet as v1.37.0. A PR on multiple targets would be nice :)

@PhyxionNL
Copy link
Contributor Author

I wish I could help but I'm not an expert with NuGet. I do know that several NuGet packages have multiple targets so it should be possible. The NuGet 1.37.0 is still only the PCL so not useful yet for .NET 4.0 clients.

That said, I think it might be possible to just add the 4.0 dll to the "lib\net40" folder as I'm not seeing anything differently in the other files with NuGet packages that have multiple targets. I think this will suffice:
master...Phyxion:patch-1

@MehdiK
Copy link
Member

MehdiK commented Jul 4, 2015

It takes a bit more work than that. The build script should move the result of different profiles into different folders which get copied into the NuGet folder structure and then packaged up. This is a needed change and we will tackle it.

@PhyxionNL
Copy link
Contributor Author

I expected as much, it looked a bit too easy. Looking forward to your commit for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants