Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Portuguese translations as pt #602

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Conversation

hangy
Copy link
Contributor

@hangy hangy commented Dec 7, 2016

Registering the Portuguese translations as pt instead of pt-BR fixes #601.

According to Humanizr#601, the localisation is good for
Portuguese in general, not just for Brazilian Portuguese.
I copied the unit test, so that we can prove that there's no regression.

Additionally, I copied the `OrginalizeTests`, because those were
already registered as "pt", not "pt-BR".

Note that `NumberToWords` is still only valid for pt-BR unless confirmed
otherwise.
@hazzik hazzik merged commit f8772c7 into Humanizr:dev Dec 8, 2016
@hazzik
Copy link
Member

hazzik commented Dec 8, 2016

Thanks

@hangy hangy deleted the issue601 branch December 8, 2016 22:35
@clairernovotny clairernovotny modified the milestone: v2.2 Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants