Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserify Transform Errors #8

Closed
cesutherland opened this issue Dec 3, 2014 · 3 comments
Closed

Browserify Transform Errors #8

cesutherland opened this issue Dec 3, 2014 · 3 comments
Labels
bug

Comments

@cesutherland
Copy link
Member

Browserify trask crashes on transform errors (eg. incorrect handlebars syntax).
@cesutherland
Copy link
Member Author

See browserify/browserify#763

@cesutherland
Copy link
Member Author

The particular issue I saw was in handlebars. The plugin itself was not emitting transform errors. See esamattis/node-hbsfy#38

cesutherland added a commit that referenced this issue Dec 3, 2014
@cesutherland
Move error handling ahead of exorcist.
f9fcdf8 
Otherwise errors are not handled by the time the streem continues down
the pipe, and we will crash.  For #8.
@cesutherland
Copy link
Member Author

This is handled correctly on our end. It is the responsibility of individual transform plugins to emit errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cesutherland