added the SplitRecord processor #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalam
requested changes
Oct 7, 2019
| <dependency> | ||
| <groupId>org.scala-lang</groupId> | ||
| <artifactId>scala-library</artifactId> | ||
| <version>2.12.9</version> |
There was a problem hiding this comment.
do we really need to upgrade scala version here ?
when working with spark this kind of changes must be hardly motivated
| final boolean keepParent = context.getPropertyValue(KEEP_PARENT_RECORD).asBoolean(); | ||
| final boolean keepParentType = context.getPropertyValue(KEEP_PARENT_RECORD_TYPE).asBoolean(); | ||
| final boolean keepParentTime = context.getPropertyValue(KEEP_PARENT_RECORD_TIME).asBoolean(); | ||
| Collection<Record> oringinRecods = new ArrayList<>(); |
| for (String field : fieldNames) { | ||
| if (record.hasField(field)) | ||
| map.put(field, record.getField(field)); | ||
| else throw new IllegalArgumentException("there is no field " + field); |
There was a problem hiding this comment.
should not throw an exception here, but log an error instead.
process() method shall never exit with an exception
...rs/logisland-processor-common/src/main/java/com/hurence/logisland/processor/SplitRecord.java
Show resolved
Hide resolved
| if (keepParentType) { | ||
| recordType = record.getType(); | ||
| } else {recordType = newRecordType;} | ||
| Record newRecord = new StandardRecord().setFields(map).setType(recordType).setTime(recordTime).setId(newRecordType); |
There was a problem hiding this comment.
record_id must not be the record_type ! use the GUID by default in StandardRecord
...ogisland-processor-common/src/test/java/com/hurence/logisland/processor/SplitRecordTest.java
Show resolved
Hide resolved
oalam
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.