Feature/logisland 483 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniPlayer
reviewed
Oct 21, 2019
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * <p> |
There was a problem hiding this comment.
Why putting those balises here ?
| @@ -161,7 +160,7 @@ | |||
| private IdBuilder idBuilder = null; | |||
|
|
|||
| @Override | |||
| public void init(ProcessContext context) throws InitializationException { | |||
| public void init(ProcessContext context) throws InitializationException { | |||
There was a problem hiding this comment.
strange indentation here
| @@ -112,7 +110,7 @@ protected PropertyDescriptor getSupportedDynamicPropertyDescriptor(final String | |||
| } | |||
|
|
|||
| @Override | |||
| public void init(final ProcessContext context) throws InitializationException { | |||
| public void init(final ProcessContext context) throws InitializationException{ | |||
| * Copyright (C) 2016 Hurence (support@hurence.com) | ||
| * | ||
| * Copyright (C) 2019 Hurence (support@hurence.com) | ||
| * <p> |
There was a problem hiding this comment.
Why these balises are here ?
| * Copyright (C) 2016 Hurence (support@hurence.com) | ||
| * | ||
| * Copyright (C) 2019 Hurence (support@hurence.com) | ||
| * <p> |
| @@ -1,19 +0,0 @@ | |||
| .. _dev-engines: | |||
|
|
|||
| Engines | |||
There was a problem hiding this comment.
why deleting this file ?
| @@ -1,17 +0,0 @@ | |||
| .. _dev-components: | |||
There was a problem hiding this comment.
why deleting this file ? Well this question for every doc files deleted
| @@ -89,6 +89,7 @@ public static void main(String[] args) { | |||
|
|
|||
| File rootDocDir = new File(dir); | |||
| DocGeneratorUtils.generate(rootDocDir, fileName, "rst", append); | |||
| DocGeneratorUtils.generate(rootDocDir, "components", "yaml", append); | |||
There was a problem hiding this comment.
Why replacing a filename parameter in command line with a hard coded string ?
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Copyright (C) 2016 Hurence (support@hurence.com) | |||
| * | |||
| * <p> | |||
| .entrySet() | ||
| .forEach(entry -> { | ||
|
|
||
| /* String category = entry.getKey(); |
There was a problem hiding this comment.
is this commented code needed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate yaml doc