Feature/url cleanner #568
Merged
Feature/url cleanner #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it decode the query params values. If we want to use URIBuilder we should use it at the same time we decode the URI.
…uery ti be between the first question mark '?' and then ended by the first number sign '#'. The query params are considered to be separated by '&' and their name and value by '='.
…bugs. Added asChar method to PropertyValue. Added parameter to choose separator for parameters in query part of the uri.
…he java URI class.
… 'a=&c' was transformed into 'a&c' therefore was not keeping the '=' was here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added URLCleaner, see issue #567 .
In addition to those changes, I cleaned up the URLDecoder by removing unused properties. And adding error in record when the parsing fails (log in an error as well in logs). I changed the log level from WARN to ERROR, maybe this could be an issue (log spamming) ? Tell me if this is the case.
I also added a URIDecoder processor that decode an URI using the java.net.URI.
But the string being decoded must be a correctly formed URI (so not already decoded for exemple as it may result in illegal characters).