Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saas/standard events feed #574

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Conversation

Jimmy-Newtron
Copy link
Collaborator

No description provided.

Copy link
Contributor

@MiniPlayer MiniPlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nickel. Juste une broutille sur le sensitive (voir remarque)

.name("geolocation.output.field.name")
.description("Label used to name the output record field for geolocation properties")
.required(false)
.sensitive(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensitive n'est pas utilisé actuellement je crois. Mais je ne pense pas que cette conf le soit XD. Ca serait plus pour des password ou autre.

@@ -41,6 +41,18 @@
* @return the json converted record
*/
static String convertToString(Record record) {
return convertToString(record, new String("location"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I detect that this code is problematic. According to the Performance (PERFORMANCE), Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR).
Using the java.lang.String(String) constructor wastes memory because the object so constructed will be functionally indistinguishable from the String passed as a parameter.  Just use the argument String directly.

@MiniPlayer MiniPlayer changed the base branch from webanalyticBug to release/v1.4.0 April 29, 2021 09:52
@MiniPlayer MiniPlayer merged commit de77567 into release/v1.4.0 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants