Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linkify treats non-breaking space characters as part of URLs #162

Closed
dbkr opened this issue Sep 21, 2016 · 2 comments
Closed

Linkify treats non-breaking space characters as part of URLs #162

dbkr opened this issue Sep 21, 2016 · 2 comments

Comments

@dbkr
Copy link
Contributor

dbkr commented Sep 21, 2016

Somewhere between 2.0.0-beta.4 and 2.1.0, linkify changed behaviour such that the nonbreaking space character is now treated as part of a URL. We have a particular piece of (user generated) content that has two URLs separated by a nonbreaking space which is parsed as one big URL in 2.1.0, instead of two separate ones.

I'm not sure if this change was intentional, although I imagine it would normally make more sense to treat nonbreaking spaces the same as any other spaces, which would not be treated as part of a URL.
@dbkr dbkr mentioned this issue Sep 21, 2016
Closed
@nfrasser
Copy link
Collaborator

Hey @dbkr, I can confirm that this is definitely a bug. It was introduced in #149, where the internal whitespace parsing was tweaked to use an array of whitespace characters. This array omits the non-breaking space character.

I'm issuing a fix for this now.

nfrasser added a commit that referenced this issue Sep 21, 2016
@nfrasser
Detect additional whitespace characters
4b89616 
Including non-breaking space. Fixes #162
@nfrasser nfrasser mentioned this issue Sep 21, 2016
Merged
nfrasser added a commit that referenced this issue Sep 21, 2016
@nfrasser
Detect additional whitespace characters (#163)
a3f6901 
* Detect  additional whitespace characters

Including non-breaking space. Fixes #162

* Avoid double export in options.js
@nfrasser
Copy link
Collaborator

Fixed in v2.1.1

@dbkr dbkr mentioned this issue Sep 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @nfrasser