Use weak references in register_*
functions so that garbage collection still works
#3135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3131; this is a nice performance optimization for anyone registering lots of transient
Random
instances.I experimented with using the same technique under
register_type_strategy()
etc., but there are so many can't-be-weak caches, closures, and references involved in strategy internals that there's no practical way to make it happen without serious performance degradation.The exception to that is
unwrap_cache
, where if the outer strategy is dropped we certainly don't need to remember what it wrapped; it's a small but cheap memory-use reduction.