Test against Pyodide / Emscripten in CI #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
pyodide-in-ci
branch
6 times, most recently
from
b0648e2
to
c981939
Compare
Zac-HD
changed the title
|
I'm amazed this works at all. Will review later. |
jobh
reviewed
Feb 3, 2024
| pyodide_version = re.findall( | ||
| f"pyodide_build-{vers_re}-py3-none-any.whl", | ||
| requests.get("https://pypi.org/simple/pyodide-build/").text, | ||
| )[-1] |
There was a problem hiding this comment.
Are we sure it's always sorted? Anyways: https://pypi.org/pypi/pyodide-build/json provides the .info.version field
There was a problem hiding this comment.
That gives us the most recent release, but we want the largest non-prerelease version which means we can't use the json endpoint. We use the regex to exclude pre-releases, but I've also switched from indexing to max() so we won't pick up a newer release of e.g. a patch backported to an older minor version - which hasn't happened yet and seems unlikely at zerover, but it's easy to handle 😁
jobh
reviewed
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3437, after a fair bit of hacking.
I'm particularly pleased about automatically updating the pinned versions; doing so from our weekly cronjob will go a long way towards avoiding compatibility bitrot as upstream changes. (which I think is why https://zhd.dev/ghostwriter/ stopped working 😿)