Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semi-bounded all_children computation #4059

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

tybug
Copy link
Member

@tybug tybug commented Jul 27, 2024

The range for semibounded integers changes subtly based on shrink_towards(and therefore certain min/max value params). Correctly take that into account when computing all_children, and when validating forced in draw_integer.

Here's a reproducer after ~10s:

from hypothesis import *
from hypothesis import strategies as st

@given(st.integers(min_value=2**128))
@settings(max_examples=1000000)
def f(n):
    pass
f()

@tybug tybug requested a review from Zac-HD as a code owner July 27, 2024 22:30
@Zac-HD Zac-HD merged commit b861d8f into HypothesisWorks:master Jul 28, 2024
58 checks passed
@tybug tybug deleted the fix-semibounded-all-children branch July 28, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants