-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small countries #27
Small countries #27
Conversation
Added Kosovo to R10 Europe but not R5/R9 due to it not being in OECD in 1990 or EU
line formatting
Did you do a careful check that all countries are now added at each R5, R9 and R10 level? Seems that at least Liechtenstein was only added at R10? |
I did not include Liechtenstein, Andorra, and San Marino in the R5/R9 regions because they are not in the OECD or the EU or an EU candidate. If the geopolitical criteria is not strict I can just add these three countries to the R5 'OECD and EU' and R9 'Other OECD (membership status 1990) and EU candidate countries' ? Kosovo is an EU candidate so I will add that to R5 'OECD and EU' and R9 'Other OECD (membership status 1990) and EU candidate countries'. |
I think the most important consideration is that every country exists somewhere in R5, R9 and R10 - or in none at all. Otherwise, doing automated aggregation from national-level data may become inconsistent - and the sum of R5, R9 and R10 should always be identical. |
Ok, that makes sense. In that case I will remove Liechtenstein, Andorra, Monaco and San Marino from the R10 regions. Then the total list of small countries added to regions at all three levels in this PR are: Kosovo, Seychelles, Antigua and Barbuda, Saint Kitts and Nevis, Saint Vincent and the Grenadines, Cook Islands, Kiribati, the Marshall Islands, Nauru, Niue, Palau, Tuvalu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Fix inconsistent small countries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for adding small countries
definitions/region/common.yaml
Outdated
Guatemala, Guyana, Haiti, Honduras, Jamaica, Martinique, Mexico, Nicaragua, | ||
Panama, Paraguay, Peru, Puerto Rico, Saint Lucia, Suriname, Trinidad and Tobago, | ||
Uruguay, Venezuela | ||
countries: Antigua and Barbuda, Argentina, Bahamas, Barbados, Belize, Bolivia, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
countries: Antigua and Barbuda, Argentina, Bahamas, Barbados, Belize, Bolivia, | |
countries: Antigua and Barbuda, Argentina, Aruba, Bahamas, Barbados, Belize, Bolivia, |
Added small countries that were in IPCC WGIII Annex II (https://www.ipcc.ch/report/ar6/wg3/downloads/report/IPCC_AR6_WGIII_Annex-II.pdf) but were not in existing list.
These were Seychelles, Andorra, Liechtenstein, Monaco, San Marino, Antigua and Barbuda, Saint Kitts and Nevis, Saint Vincent and the Grenadines, Cook Islands, Kiribati, the Marshall Islands, Nauru, Niue, Palau, Tuvalu,
Also added Kosovo to R10 Europe for aggregation purposes.