-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against adding deprecated legacy variables #61
Guard against adding deprecated legacy variables #61
Conversation
The validation can be seen "in action" here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a few small comments but already good to merge.
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
Thanks @phackstock - I prefer to keep the requirements.txt file for now because this is an easy way for new users to quickly see what is required to run this project. We can add it to the Readme instead in a follow-up PR. |
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
This PR adds a test and GitHub Actions workflow to guard against mistakenly adding variables that were marked as being superseded by new variables.
The way that legacy variables are marked in the common-definitions repository is by having an attribute with the legacy project name, currently "navigate" and "engage".
The test workflow checks that all such attributes are not duplicates of variables in the VariableCodeList.