-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs/add howto #144
Docs/add howto #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first draft @phackstock. I made some suggestions, please also revise for more concise language.
Most importantly, I would frame this page as "Model registration", because we may want to add other types of model registration (e.g., use MAGICC for post-processing) here.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Thanks for the first round of comments @danielhuppmann. I implemented them and made the language more concise. Hope that's a step in the right direction. |
The explanation makes sense yes! I find the difference between native and common regions hard to grasp in general and in this article, but that might just be because I do not work with the data. I'll let you see if it is useful to add something on that or if people working with the package are expected to know it. |
@luciecastella thanks for the quick review. Good to hear that it made sense to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more minor suggestions inline, then good to be merged.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Thanks @luciecastella for your comments. Please also use the "Approve" feature so that your approval can easily be seen in the status overview of the PR. Based on your remarks, I started a new issue #145, which you and @phackstock can tackle in a follow-up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me :)
I renamed the file from |
Yes, good idea. |
Closes #142.
Opened in favor of #143.
This is my first attempt at a "how to" detailing the common pitfall of adding a model mapping without the corresponding region definition files.
As the "how to" referenced the nomenclature validate-project cli command, I added some additional docstring explanation that does not seem to be rendered currently by sphinx-click. Additionally, the direct referencing of a cli command seems to not be possible at the moment (https://sphinx-click.readthedocs.io/en/latest/usage/#cross-referencing) so I liked the CLI page.
A preview of the updated docs is rendered here: https://nomenclature-iamc.readthedocs.io/en/docs-add-howto/