Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RegionProcessor #213

Merged
merged 12 commits into from
Jan 10, 2023
Merged

Refactor RegionProcessor #213

merged 12 commits into from
Jan 10, 2023

Commits on Jan 9, 2023

  1. Add drop_negative_weights to VariableCode

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    328f57d View commit details
    Browse the repository at this point in the history

  2. Add aggregation aggs properties to VariableCode

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    e22a0e7 View commit details
    Browse the repository at this point in the history

  3. Make usage of VariableCode more consistent

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    0b7073a View commit details
    Browse the repository at this point in the history

  4. Add variable selection method based on agg args

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    605bc35 View commit details
    Browse the repository at this point in the history

  5. Remove no longer needed global variables

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    67e69cf View commit details
    Browse the repository at this point in the history

  6. Clean up unused imports

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    daffef7 View commit details
    Browse the repository at this point in the history

  7. Make check_unexpected_regions method of RegionAggregationMapping

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    9c58ed6 View commit details
    Browse the repository at this point in the history

  8. Refactor region processing

    @phackstock
    phackstock committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    8fd4f1f View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
    @phackstock @danielhuppmann
    phackstock and danielhuppmann authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e0d25e4 View commit details
    Browse the repository at this point in the history

  2. Change order of pyam agg kwrgs for consistency

    @phackstock
    phackstock committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c92a674 View commit details
    Browse the repository at this point in the history

  3. Appease stickler

    @phackstock
    phackstock committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    122a0d9 View commit details
    Browse the repository at this point in the history

  4. Use proper docstring

    @phackstock
    phackstock committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8434b54 View commit details
    Browse the repository at this point in the history