Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test after pandas 2.0 update #235

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix failing test after pandas 2.0 update #235

merged 1 commit into from
Apr 5, 2023

Conversation

phackstock
Copy link
Contributor

@phackstock phackstock commented Apr 5, 2023 •
edited
Loading

closes #234.
Did a quick check locally, seems to work fine as well with pandas 1.5.2 so should be all good.

@phackstock phackstock added the bug Something isn't working label Apr 5, 2023
@phackstock phackstock self-assigned this Apr 5, 2023
danielhuppmann
danielhuppmann approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@phackstock phackstock merged commit 72e658e into IAMconsortium:main Apr 5, 2023
@phackstock phackstock deleted the fix/pandas2.0 branch April 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

@GretchenSchowalter GretchenSchowalter Awaiting requested review from GretchenSchowalter

Assignees

@phackstock phackstock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pandas 2.0 breaks test_check_aggregate.expected_fail_return
2 participants
@phackstock @danielhuppmann