General cleanup #244
Merged
General cleanup #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
force-pushed
the
bug/remove-all-mutable-defaults
branch
from
91baf31
to
126a5b2
Compare
|
@phackstock, can you please do a rebase before I review? |
phackstock
force-pushed
the
bug/remove-all-mutable-defaults
branch
from
126a5b2
to
d63dc28
Compare
|
@danielhuppmann everything rebased, good to review now. |
danielhuppmann
approved these changes
May 17, 2023
|
Yes, nothing major, I just fixed a bunch of stuff that pylint found while I was at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I ran into an issue with a mutable default argument in #243, this PR eliminates the two remaining ones in the package.
Since this is, on purpose, branched off of #243, the idea would be to first merge #243 and then this one.
Update
I used pylint to find the mutable defaults. While I was there I also fixed some other issues that it found.