Add a module for translating between country names and alpha-2/3 codes #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willu47, this PR implements an all-directions ISO2/ISO3-country-name mapping similar to the pycountry package, i.e., from nomenclature import countries
name = countries.get(alpha_3="...").name
alpha_3 = countries.get(name="...").alpha_3From my point of view, it's preferable to have one versatile mapping rather than numerous distinct |
phackstock
reviewed
Jul 19, 2023
| obj = self.data_class(**entry) | ||
| self.objects.append(obj) | ||
|
|
||
| for key, value in entry.items(): |
There was a problem hiding this comment.
I've tried fully wrapping my head around what's going on here but failed to grasp all the details.
Since it's adapted from pycountry.db.Database I assume this is fine.
phackstock
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Thanks for the updates @danielhuppmann.
Good to be merged from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a suggestion by @willu47, this PR adds a shim of the pycountry.countries feature offering a simple translation between country names (as commonly used in the modelling community) and alpha-3/alpha-2 codes including the special use of alpha-2 by the European Commission.