-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RegionProcessor.revert() #279
Add RegionProcessor.revert() #279
Conversation
8afd042
to
a8303a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, but is there a particular reason for using a subclass instead of a method like RegionProcessor.revert()
?
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
…-region-processor' Conflicts: nomenclature/processor/region.py
Updated to |
…ssor' into feature/add-reverse-region-processor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks! One more little detail inline, then good to merge.
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Closes #111.
I needed this for some climate processing for the ENGAGE project so I figured I might as well add it.
I made the choice to drop common regions, not sure if it's the best one but we can always change it later if need be.