Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RegionProcessor.revert() #279

Merged

Conversation

phackstock
Copy link
Contributor

Closes #111.
I needed this for some climate processing for the ENGAGE project so I figured I might as well add it.
I made the choice to drop common regions, not sure if it's the best one but we can always change it later if need be.

@phackstock phackstock force-pushed the feature/add-reverse-region-processor branch from 8afd042 to a8303a5 Compare September 4, 2023 17:06
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle, but is there a particular reason for using a subclass instead of a method like RegionProcessor.revert()?

nomenclature/processor/region.py Outdated Show resolved Hide resolved
phackstock and others added 3 commits September 5, 2023 09:54
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
…-region-processor'

Conflicts:
	nomenclature/processor/region.py
@phackstock
Copy link
Contributor Author

Updated to RegionProcessor.revert()

…ssor' into feature/add-reverse-region-processor
@phackstock phackstock changed the title Add ReverseRegionProcessor Add RegionProcessor.reverse() Sep 5, 2023
@phackstock phackstock changed the title Add RegionProcessor.reverse() Add RegionProcessor.revert() Sep 5, 2023
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! One more little detail inline, then good to merge.

nomenclature/processor/region.py Outdated Show resolved Hide resolved
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@phackstock phackstock merged commit 400d08b into IAMconsortium:main Sep 5, 2023
2 of 8 checks passed
@phackstock phackstock deleted the feature/add-reverse-region-processor branch September 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement processor to "undo" region processing
2 participants