Add VariableCodeList.units attribute and tests
#289
Conversation
nomenclature/codelist.py
Outdated
| else: | ||
| unit_set.add(variable.unit) | ||
|
|
||
| return list(unit_set) |
There was a problem hiding this comment.
Do you need to return a list? Wouldn't it work as well if you just returned the set?
There was a problem hiding this comment.
Call me old-fashioned, but I have cast all return-objects in pyam (index dimensions, etc.) to lists for consistency...
On second thought, I would actually not follow pint (use the string |
Sounds good as well. I agree with your point that it's more in line with closely reproducing what's the yaml files. |
I just ran into a situation where I wanted to get all units from a VariableCodeList, so this PR adds an attribute for that...
Open question: going back and forth between set and list seems to make the order arbitrary, but allowing "None" (for dimensionless variables) also preempts ordering easily. One could simply drop "None" from that list (given that it's not a unit) or we could always add it at the end or replace by "dimensionless" (this is what pint does)...