Bring cli back #300
Merged
Bring cli back #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhuppmann
approved these changes
Jan 5, 2024
I would assume so too, seeing as there were already some special settings required in the test GitHub action to get it running on Windows I would say it's OS related. I tried a couple of things but couldn't get it to work easily so I (for now) marked it as expected to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #299.
This PR brings back the cli which was accidentally dropped in v0.13.0.
It also adds an explicit test to see if the command
nomenclatureis recognized by the system after install.Previously we'd only been using the test runner from click which seemingly also works if the cli is not actually installed. This is why this error was not caught.