Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum use in config #356

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix enum use in config #356

merged 2 commits into from
Jul 9, 2024

Conversation

phackstock
Copy link
Contributor

Closes #355 and adds an explicit test for getting DataStructureDefinitions from config file.

@phackstock phackstock added the bug Something isn't working label Jul 9, 2024
@phackstock phackstock self-assigned this Jul 9, 2024
danielhuppmann
danielhuppmann approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@phackstock phackstock merged commit bc5a133 into IAMconsortium:main Jul 9, 2024
11 checks passed
@phackstock phackstock deleted the hotfix/enum-use-in-config branch July 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@phackstock phackstock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dimensions attribute in config file not correctly converted into path
2 participants
@phackstock @danielhuppmann