Add parsing of data-validation yaml files #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
approved these changes
Aug 12, 2024
| data_validator.validate_with_definition(dsd) | ||
|
|
||
| # validating against a DataStructure without the offending dimension passes | ||
| dsd = DataStructureDefinition( |
There was a problem hiding this comment.
You're already testing a compliant DataValidator above in test_DataValidator_from_file so I'd say you can remove those lines from the test and just test for the error.
There was a problem hiding this comment.
Well, the idea here was to test here that really only the dimensions are tested where a codelist exists in the DataStructureDefinition. Tried to explain that in the docstring, but not clear enough, I guess...
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a class
DataValidator, enables parsing the validation criteria from a yaml file and makes sure that the filter criteria are defined in a DataStructureDefinition (only if that dimension is defined there).