Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data validation using value and tolerance (subclass implementation) #371

Merged

Conversation

phackstock
Copy link
Contributor

No description provided.

@phackstock phackstock added the enhancement New feature or request label Aug 29, 2024
@phackstock phackstock self-assigned this Aug 29, 2024
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Increasing the pydantery to the maximum...

A few suggestions inline, then good to be merged!

nomenclature/processor/data_validator.py Outdated Show resolved Hide resolved
tests/test_validate_data.py Outdated Show resolved Hide resolved
nomenclature/processor/data_validator.py Outdated Show resolved Hide resolved
nomenclature/processor/data_validator.py Outdated Show resolved Hide resolved
tests/test_validate_data.py Outdated Show resolved Hide resolved
phackstock and others added 2 commits August 29, 2024 16:30
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
@phackstock phackstock merged commit cee0ed1 into IAMconsortium:main Aug 29, 2024
8 checks passed
@phackstock phackstock deleted the feature/validate-range-subclasses branch August 29, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants