-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AR6 category colors to PYAM_COLORS #650
Conversation
Thanks so much, @jkikstra! Can you also update the plot used to test against (and confirm it looks correct)? Instructions to do so should be in the |
Have updated the test figures. Tests locally are failing, but that seems to be due to |
Thanks @jarmo! I pinned pint as a quickfix, this should resolve the failing unit tests in this PR. Could you please do the following:
Then good to go, and I think this is a nice feature addition that warrants a new release (which I will take of). |
This reverts commit 56fcc56.
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
=====================================
Coverage 94.5% 94.5%
=====================================
Files 57 57
Lines 5662 5662
=====================================
Hits 5356 5356
Misses 306 306
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jkikstra for adding the colors and docs!
The IPCC-colors tutorial notebook is run automatically as part of building the docs, so this will show the added AR6 colors. No need to change anything explicitly.
Description of PR
Adds the AR6 Category and IMP colours to pyam.