Fix/concat #665
Merged
Fix/concat #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
=====================================
Coverage 94.5% 94.5%
=====================================
Files 59 59
Lines 5742 5747 +5
=====================================
+ Hits 5431 5436 +5
Misses 311 311
Continue to review full report at Codecov.
|
danielhuppmann
approved these changes
May 24, 2022
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
|
Thanks for the quick review @danielhuppmann. If the tests all run through I'd go ahead with the merge. |
|
Thanks for that! I literally stumbled over it last night. |
|
Perfect coincidence then, happy to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
closes #664.
The
pyam.concatfunction now carries over the index of the merged meta table.Added a unit test to check under
test_feature_append_and_concat.test_concat_non_standard_index.For documentation I added an additional line to the
notessection of thepyam.concatfunction.One open question from my side would be if there is more documentation than the added docstring required. My hunch would be that it's fine as is since the behavior is not really new but rather more working in line with user expectations.