-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add filtering by index #674
Conversation
Needs documentation and a test. Extend when you have the time. I'll try to do something about it tmw. |
Failing tests are iiasa and unfcc connectors. Pbb unrelated to this PR. |
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
=====================================
Coverage 94.7% 94.7%
=====================================
Files 59 59
Lines 5768 5800 +32
=====================================
+ Hits 5463 5495 +32
Misses 305 305
Continue to review full report at Codecov.
|
Thanks for fixing, @danielhuppmann . Incorporated. |
I've added minimal docstrings and to the release notes. @coroa this looks good to go from my side - good for you? |
And any final thoughts from @danielhuppmann also welcome. Unless there's more to add, will merge when tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion to add the pandas.MultiIndex explicitly to the docs, otherwise - awesome!
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Thank you @coroa ! |
Good to go from my side :) |
Fixes #673 .
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Tentative implementation for a filter kwarg supporting to select a list of pathways.