Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two failing tests #675

Merged
merged 8 commits into from
Jun 28, 2022

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jun 28, 2022

Description of PR

This PR fixes two failing tests:

  • for some reason, the UNFCCC inventory changes from time to time (marginally but enough to trip the tests)
  • change the implementation of the IIASA API tests

The IIASA "integration-test" database instance was now set to public, the configurations were defined incorrectly as part of the migration to a new services-manager (see here for more info).

@danielhuppmann danielhuppmann self-assigned this Jun 28, 2022
@danielhuppmann danielhuppmann marked this pull request as ready for review June 28, 2022 12:30
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #675 (a7b17f0) into main (516da60) will increase coverage by 0.0%.
The diff coverage is 91.6%.

@@          Coverage Diff          @@
##            main    #675   +/-   ##
=====================================
  Coverage   94.6%   94.7%           
=====================================
  Files         59      59           
  Lines       5776    5768    -8     
=====================================
- Hits        5465    5463    -2     
+ Misses       311     305    -6     
Impacted Files Coverage Δ
tests/test_unfccc.py 100.0% <ø> (ø)
pyam/iiasa.py 85.8% <75.0%> (-0.1%) ⬇️
tests/test_iiasa.py 96.8% <100.0%> (+4.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516da60...a7b17f0. Read the comment docs.

@danielhuppmann danielhuppmann merged commit 52b4d03 into IAMconsortium:main Jun 28, 2022
@danielhuppmann danielhuppmann deleted the quickfix/tests branch June 28, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant