-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add weighted quantiles #686
Conversation
Codecov Report
@@ Coverage Diff @@
## main #686 +/- ##
=====================================
Coverage 94.8% 94.9%
=====================================
Files 58 59 +1
Lines 5899 5990 +91
=====================================
+ Hits 5598 5690 +92
+ Misses 301 300 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks @gidden, this sounds really useful! A few comments:
|
@danielhuppmann - FYI - I am seeing test failures in I'm also hoping to clean this up, time permitting, in the next days. |
But all checks except one passed, so I guess that the Woldbank-server just had a hick-up in that second. Re-running the failed test might do the trick... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few minor suggestions inline!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three more minor fixes, then good to be merged. Thanks for adding a tutorial!
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
Co-authored-by: Daniel Huppmann <dh@dergelbesalon.at>
all committed, should be g2g @danielhuppmann ! Thanks for the review! |
Release notes are still missing - pretty please! |
Release notes updated and issues made @danielhuppmann |
Thanks @gidden! |
Description of PR
Adds a
df.quantile()
function which calculates (possibly weighted) quantiles for a variable across a population of models and scenarios.If this feature is useful for others in the community, I'm happy to improve the PR, add a tutorial, etc.
cc @chrisroadmap
Please confirm that this PR has done the following:
[ ] Name of contributors Added to AUTHORS.rstTODOS - issues
model
)weights
argumentAdding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following: