Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct order of time attribute #723

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 22, 2022

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR modifies how the values for the time attribute are retrieved, fixing a bug where the order may not have been correct.

Closes #722

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #723 (9854cca) into main (a39fdca) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #723   +/-   ##
=====================================
  Coverage   95.0%   95.0%           
=====================================
  Files         59      59           
  Lines       5998    6003    +5     
=====================================
+ Hits        5702    5707    +5     
  Misses       296     296           
Impacted Files Coverage Δ
pyam/core.py 95.4% <ø> (ø)
tests/test_core.py 100.0% <100.0%> (ø)
tests/test_time.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielhuppmann danielhuppmann marked this pull request as ready for review December 22, 2022 09:26
@danielhuppmann danielhuppmann merged commit d75d4ce into IAMconsortium:main Dec 22, 2022
@danielhuppmann danielhuppmann deleted the time/order branch December 22, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sorting for time attribute
1 participant