-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use ixmp4 #766
Refactor to use ixmp4 #766
Conversation
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
=======================================
+ Coverage 94.4% 94.6% +0.2%
=======================================
Files 62 62
Lines 6132 6107 -25
=======================================
- Hits 5789 5779 -10
+ Misses 343 328 -15
|
Quick question about future logins for non-ixmp4 projects. Say I need to read some data from the private NGFS phase 4 internal scenario Explorer after this change is live on pyam. Can I do that then? |
Good question, and please suggest how to make this clearer in the docs (if you think it's necessary). Setting your credentials using If you have already set your credentials via pyam v1.x and simply pull the latest version of pyam (and install ixmp4) and do nothing else, doing
|
Ah ok I see that's good to know. I'll suggest an update to the docs then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some small comments below.
One question regarding the tests. Is there an explicit test for authentication using ixmp4? I tried and didn't see one but maybe it's all there anyway.
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
@meksor added several tests in ixmp4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, ready to be merged.
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR refactors the
ScSeAuth
class to not retrieve the token for connecting to a Scenario-Explorer database directly but instead use the default-auth from the ixmp4 package.Because ixmp4 0.2.0 only supports python 3.10, older Python versions are remove and 3.11-tests are currently disabled.
There are two issues that make this new dependency a bit more elaborate than necessary: