Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map_regions() and default mappings csv #773

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Aug 23, 2023

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR removes the (not in use any more) method map_regions() method and a default-mappings csv file. This functionality is now taken over by the nomenclature.RegionProcessor class. A reference to the nomenclature user guide is added to the aggregate_region() documentation.

Closes #765

@danielhuppmann danielhuppmann requested a review from gidden August 23, 2023 16:07
@danielhuppmann danielhuppmann self-assigned this Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #773 (074c51e) into main (525ede9) will decrease coverage by 0.2%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##            main    #773     +/-   ##
=======================================
- Coverage   94.6%   94.5%   -0.2%     
=======================================
  Files         62      62             
  Lines       6107    6027     -80     
=======================================
- Hits        5779    5696     -83     
- Misses       328     331      +3     
Files Changed Coverage Δ
pyam/core.py 95.0% <0.0%> (-0.2%) ⬇️
pyam/run_control.py 72.0% <ø> (ø)
tests/test_core.py 100.0% <ø> (ø)

... and 2 files with indirect coverage changes

@danielhuppmann danielhuppmann marked this pull request as ready for review August 23, 2023 16:17
@gidden
Copy link
Member

gidden commented Aug 28, 2023

Thanks @danielhuppmann - lgtm

@gidden gidden merged commit b16ae63 into IAMconsortium:main Aug 28, 2023
@danielhuppmann danielhuppmann deleted the deprecate/region-maps branch August 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove region-mappings from pyam core
2 participants