-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pyam.iiasa.platforms()
function
#829
Add a pyam.iiasa.platforms()
function
#829
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
=====================================
Coverage 94.8% 94.8%
=====================================
Files 64 64
Lines 6125 6144 +19
=====================================
+ Hits 5810 5829 +19
Misses 315 315 ☔ View full report in Codecov by Sentry. |
Hm it would be useful to see if one is connecting via rest or sqlalchemy, maybe just showing the protocol part of the dsn? |
My suggestion only refers to the attributes when connecting via the manager - the toml would still have the dsn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge from my side, just two small comments
pyam.iiasa.list_platforms()
functionpyam.iiasa.platforms()
function
Ah I see, alright convinced! |
Please confirm that this PR has done the following:
Tests AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR adds a method
pyam.iiasa.list_platforms()
as a shorthand for the ixmp4 function down in the config hierarchy, producing an output like:I modified this from the corresponding method in ixmp4 showing name, access level and notice (instead of dsn), because this seems more relevant for a Python-API-user.
@meksor, if you agree, I can implement the corresponding change in ixmp4?
Update
Renamed the function to
pyam.iiasa.connections()
to avoid naming conflict with the ixmp4 method.