-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing filters when reading from an ixmp4 platform #838
Allow passing filters when reading from an ixmp4 platform #838
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=======================================
- Coverage 95.0% 95.0% -0.1%
=======================================
Files 64 63 -1
Lines 6134 6150 +16
=======================================
+ Hits 5828 5843 +15
- Misses 306 307 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall.
Some minor comments in line.
Co-authored-by: Philip Hackstock <20710924+phackstock@users.noreply.github.com>
Responding here to a larger comment by @phackstock in the review: this PR only touches the But a user will still have the possibility to make that selection explicitly either using: df_ixmp = pyam.iiasa.Connection(name).query(**filters)
df_ixmp4 = pyam.read_ixmp4(name, **filters) It is our responsibility to keep potential overlaps of "database existence" to a minimum and keep the actual data consistent between new and legacy instances. |
@danielhuppmann sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to be merged from my side
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR allows passing filters when reading from an ixmp4 platform and it extends
read_iiasa()
to first try reading from ixmp4 platforms hosted by IIASA.